impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation
Date Wed, 26 Apr 2017 03:29:14 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6724/2/be/src/testutil/test-udas.cc
File be/src/testutil/test-udas.cc:

PS2, Line 148:   assert(context->GetNumArgs() == 3);
             :   assert(context->GetArgType(0)->type == FunctionContext::TYPE_DECIMAL);
             :   assert(context->GetArgType(0)->precision == 20);
             :   assert(context->GetArgType(0)->scale == 10);
             :   assert(context->GetArgType(1)->type == FunctionContext::TYPE_BIGINT);
             :   assert(context->GetArgType(2)->type == FunctionContext::TYPE_STRING);
             :   assert(context->GetIntermediateType().type == FunctionContext::TYPE_STRING);
             :   assert(context->GetReturnType().type == FunctionContext::TYPE_DECIMAL);
             :   assert(context->GetReturnType().precision == 38);
             :   assert(context->GetReturnType().scale == 21);
these are the same set of asserts in each function, right? (which is kind of the point). That
would be more obvious if you factored them into a subroutine that you just call from each.


-- 
To view, visit http://gerrit.cloudera.org:8080/6724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I158303b20d1afdff23c67f3338b9c4af2ad80691
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message