impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR
Date Tue, 25 Apr 2017 22:20:18 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5192: Don't bake MemPool* into IR
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6657/4/be/src/runtime/tuple.cc
File be/src/runtime/tuple.cc:

Line 299:   }
why is this a return status now? we don't want to have callsites do this (and we know that
they don't), right?


-- 
To view, visit http://gerrit.cloudera.org:8080/6657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message