impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().
Date Tue, 25 Apr 2017 21:18:13 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr().
......................................................................


Patch Set 5:

(2 comments)

Patch set 5 specifically for Jim's last 2 'PS4' comments. The line 335 and 406 ones I'll look
at in a separate patch set.

http://gerrit.cloudera.org:8080/#/c/5589/4/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

PS4, Line 352: -- specified position, the result is 0.
> not exactly: that position does not exist.
Sure, I'll lower the number so it's a valid position within the string that still returns
a 0 result.


PS4, Line 415: fourt
> fourth
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi+gerrit@cloudera.com>
Gerrit-Reviewer: zi+zicl@cloudera.com
Gerrit-HasComments: Yes

Mime
View raw message