impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results
Date Mon, 24 Apr 2017 20:27:57 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4266: Java udf returning string can give incorrect results
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4941/6/be/src/exprs/hive-udf-call.cc
File be/src/exprs/hive-udf-call.cc:

Line 332:   memcpy(local_alloc, result.ptr, result.len);
Hm, not good. We'll crash if local_alloc is null. Let me file a JIRA for that, we should backport
it.

I filed https://issues.apache.org/jira/browse/IMPALA-5252, please keep an eye on it.


-- 
To view, visit http://gerrit.cloudera.org:8080/4941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I705d271814cb1143f67d8a12f4fd87bab7a8e161
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message