impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Date Fri, 21 Apr 2017 21:03:44 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5222: don't call Bits::Log2*() functions
......................................................................


IMPALA-5222: don't call Bits::Log2*() functions

Some of gutil's functions are fairly inefficient. We accidentally
regressed this when switching to the new Bits::, and some of the
BufferPool code that was in flight didn't switch over.

This commit switches to calling BitUtil::Log2*() everywhere and makes
sure that those functions are all implemented in an efficient way.

Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c
Reviewed-on: http://gerrit.cloudera.org:8080/6675
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/parquet-column-readers.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/disk-io-mgr.cc
M be/src/runtime/free-pool.h
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/dict-encoding.h
M be/src/util/hdr-histogram.cc
11 files changed, 45 insertions(+), 32 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message