impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5152: Gather all tables with missing metadata in analysis
Date Fri, 21 Apr 2017 19:04:43 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5152: Gather all tables with missing metadata in analysis
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6702/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:

PS1, Line 444: loadedTables_
Name is misleading, since the tables aren't actually loaded at this point. Maybe 'requestedTables_'?


http://gerrit.cloudera.org:8080/#/c/6702/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

PS1, Line 542: if (e instanceof IncompleteMetadataException) throw e;
Any reason you sometimes handle it this way, sometimes as a separate 'catch'?


http://gerrit.cloudera.org:8080/#/c/6702/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:

Line 239:       // Ignore to collect all missing tables.
'Preconditions.checkState(analyzer.hasMissingTbls());'? and the same below


http://gerrit.cloudera.org:8080/#/c/6702/1/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java:

PS1, Line 214: if (!analyzer.hasMissingTbls()) throw e;
Check if 'e' is an IncompleteMetadataException here instead?


-- 
To view, visit http://gerrit.cloudera.org:8080/6702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10a303958557982b26a07c97a9bb30932ab44dd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message