impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.
Date Fri, 21 Apr 2017 18:04:52 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.
......................................................................


Patch Set 2:

> I added a test case, including a parquet file containing ENUM. I
 > haven't run the test though, because setting up a test environment
 > seemed to overwhelming when I tried.

dev@impala.apache.org might be a good resource for you when you get stuck on these things.
Many experienced Impala developers get stuck on these things, too.

I have started a test on Jenkins:

http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/1186/console

The output is verbose, so Lars or I or another reviewer can help you parse it when it is done.

-- 
To view, visit http://gerrit.cloudera.org:8080/6550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jakub Kukul <jakub.kukul@gmail.com>
Gerrit-Reviewer: Jakub Kukul <jakub.kukul@gmail.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message