impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4548: BlockingJoinNode should wait for async build thread
Date Thu, 20 Apr 2017 21:55:57 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4548: BlockingJoinNode should wait for async build thread
......................................................................


IMPALA-4548: BlockingJoinNode should wait for async build thread

This is a minor clean up for the handling of the async build thread
in BlockingJoinNode. In particular, the main thread used to block on
the promise passed to the async build thread and won't proceed until
the status is set. Async build thread relies on the fragile assumption
that no other states (e.g. runtime state object) will be accessed
once the promise is set. This has proven to be fragile with the
use-after-free bug in IMPALA-4532.

This change removes the reliance on fragile assumption by making
the main thread join the async build thread before proceeding.

Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342
Reviewed-on: http://gerrit.cloudera.org:8080/6664
Reviewed-by: Michael Ho <kwho@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/blocking-join-node.h
2 files changed, 21 insertions(+), 28 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Ho: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message