impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution
Date Thu, 20 Apr 2017 20:51:46 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6628/5/be/src/service/impala-server.h
File be/src/service/impala-server.h:

PS5, Line 279:   /// A map from unique backend ID to the corresponding TBackendDescriptor
of that backend.
             :   /// Used to track membership updates from the statestore so queries can be
cancelled
             :   /// when a backend is removed. It's not enough to just cancel fragments that
are running
             :   /// based on the deletions mentioned in the most recent statestore heartbeat;
sometimes
             :   /// cancellations are skipped and the statestore, at its discretion, may
send only
             :   /// a delta of the current membership so we need to compute any deletions.
             :   /// TODO: Currently there are multiple locations where cluster membership
is tracked,
             :   /// here and in the scheduler. This should be consolidated so there is a
single component
             :   /// (the scheduler?) that tracks this information and calls other interested
components.
> I think this comment is about the known_backends_ field, no?
Oops, yes.


PS5, Line 290: const BackendDescriptorMap& GetKnownBackends();
> why does this need to be exposed? where is it used?
This is used in ImpalaHttpHandler::BackendsHandler().


-- 
To view, visit http://gerrit.cloudera.org:8080/6628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2ff7f341c9d2b0649e4d14561077e166ad7c4d
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message