impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5231: skip test explain level on non-HDFS systems
Date Thu, 20 Apr 2017 16:38:06 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5231: skip test_explain_level on non-HDFS systems
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6703/1/tests/common/skip.py
File tests/common/skip.py:

PS1, Line 52: different_plans
inconsistent_plans may be a bit more clear


PS1, Line 59: SkipIf
do we need all 3, or can you just put inconsistent plans in here and apply it once in the
tests instead of all 3?


-- 
To view, visit http://gerrit.cloudera.org:8080/6703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I604f83695e956ef6bc85b5d1bc754ccb1378eda1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message