impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR
Date Thu, 20 Apr 2017 02:14:49 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5192: Don't bake MemPool* into IR

Patch Set 3:


Will post new patch after is merged.
File be/src/codegen/

PS3, Line 528: CodegenAllocate
> okay to ignore, but I think this would be clearer if called CodegenMemPoolA
File be/src/runtime/

PS3, Line 344:  // Value* non_null_string_values_arg = args[5]; // unused
             :   // Value* total_string_lengths_arg = args[6]; // unused
             :   // Value* num_non_null_string_values_arg = args[7]; // unused
> what does this mean? that these out-parameters can't be used with codegen? 
This function makes an assumption that 'collect_string_vals' is false so these arguments are
not used. Added some comments for it.
File be/src/runtime/tuple.h:

PS3, Line 121: .
> it would probably be good to mention the equivalent thing about codegen -- 

PS3, Line 167: There are two different MaterializeExprs symbols to differentiate between
             :   /// these cases when we replace the function calls during codegen.
> what is this referring to exactly? we generate two versions of the same fun
Comments updated to refer to the comment of MaterializeExprs() about the two different symbols.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message