impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5229: huge page-backed buffers with TCMalloc
Date Thu, 20 Apr 2017 01:23:40 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5229: huge page-backed buffers with TCMalloc
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6687/2/be/src/runtime/bufferpool/system-allocator.cc
File be/src/runtime/bufferpool/system-allocator.cc:

Line 50:   // Free() assumes that aggressive decommit is enabled for TCMalloc.
> I saw the comment in Free() but don't follow how that means aggressive deco
I believe MADV_NOHUGEPAGE just prevents future merging into huge pages and can leave the memory
backed by huge pages. Some people at least claim that madvise(DONTNEED) doesn't work if you
call it part of a transparent huge pages: https://www.percona.com/blog/2014/07/23/why-tokudb-hates-transparent-hugepages/


-- 
To view, visit http://gerrit.cloudera.org:8080/6687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If84b46a46efed9aee6af41b5f10bf3f4b15889b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message