impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4548: BlockingJoinNode should wait for async build thread
Date Thu, 20 Apr 2017 00:57:48 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4548: BlockingJoinNode should wait for async build thread
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6664/1/be/src/exec/blocking-join-node.h
File be/src/exec/blocking-join-node.h:

PS1, Line 207: Status* status
> why can't we return Status here?
It's called by the async build thread. Can it actually pass a status back ? Doesn't see the
appropriate interface in Thread class.


-- 
To view, visit http://gerrit.cloudera.org:8080/6664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message