impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5229: huge page-backed buffers with TCMalloc
Date Thu, 20 Apr 2017 00:55:50 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5229: huge page-backed buffers with TCMalloc
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6687/2/be/src/runtime/bufferpool/system-allocator.cc
File be/src/runtime/bufferpool/system-allocator.cc:

Line 50:   // Free() assumes that aggressive decommit is enabled for TCMalloc.
> The comment in free explains why aggressive decommit is important. Otherwis
I saw the comment in Free() but don't follow how that means aggressive decommit is important.
It seems to say that the MADV_NOHUGEPAGE is important.  But once that happens, can't the (small)
pages be returned (i.e. madvise(DONTNEED) individually?


-- 
To view, visit http://gerrit.cloudera.org:8080/6687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If84b46a46efed9aee6af41b5f10bf3f4b15889b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message