impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup
Date Thu, 20 Apr 2017 00:39:46 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5220: memory maintenance cleanup
......................................................................


Patch Set 6:

> (2 comments)
 > 
 > The consumption metric refresh shouldn't be consequential. It
 > previously was controlled by logbufsec, which defaulted to 5s. Also
 > if there are queries actually running and checking memory
 > consumption they'll force refresh of the metric, this mainly just
 > exists to prevent it getting permanently out of sync while the
 > system is idle.

I agree we don't want to rely on this, but just wanted to make sure we don't. i.e. the fix
wouldn't be to change the frequency here, but to make sure admission control updates consumption
before using it.

Anyway, I think admission control only looks at pool memtrackers, not the process tracker,
but I'm not positive.

-- 
To view, visit http://gerrit.cloudera.org:8080/6626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message