impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5229: huge page-backed buffers with TCMalloc
Date Wed, 19 Apr 2017 19:12:48 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5229: huge page-backed buffers with TCMalloc
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6687/2/be/src/runtime/bufferpool/system-allocator.cc
File be/src/runtime/bufferpool/system-allocator.cc:

Line 50:   // Free() assumes that aggressive decommit is enabled for TCMalloc.
what about Free is assuming that? why do we care how tc-malloc manages it's memory as long
as it's available for new allocations after we free()? do you mean because we're removing
that GC code in the other patch or something else?


PS2, Line 120: itcan
missing space


PS2, Line 121: SMALL_PAGE_SIZE
do we enforce that buffer sizes are larger than 4k?


-- 
To view, visit http://gerrit.cloudera.org:8080/6687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If84b46a46efed9aee6af41b5f10bf3f4b15889b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message