impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Date Wed, 19 Apr 2017 17:57:26 GMT
Joe McDonnell has posted comments on this change.

Change subject: Revert "Pass build type to Impala LZO."
......................................................................


Patch Set 3:

(1 comment)

Updated the change to pass DEBUG to LZO. My local tests show this working fine.

http://gerrit.cloudera.org:8080/#/c/6686/1/CMakeLists.txt
File CMakeLists.txt:

Line 390:     COMMAND $ENV{IMPALA_LZO}/build.sh DEBUG ${CMAKE_SOURCE_DIR}
> Joe is going to try this and post a new patch.
Switching to passing DEBUG works on my setup.


-- 
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message