impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Date Wed, 19 Apr 2017 17:40:10 GMT
Dan Hecht has posted comments on this change.

Change subject: Revert "Pass build type to Impala LZO."
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6686/1/CMakeLists.txt
File CMakeLists.txt:

Line 390:     COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_SOURCE_DIR} $ENV{IMPALA_TOOLCHAIN}
rather than reverting both changes, how about just passing "Debug" here?


-- 
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: Yes

Mime
View raw message