impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Impala ABM / LZCNT support
Date Wed, 19 Apr 2017 15:49:55 GMT
Tim Armstrong has posted comments on this change.

Change subject: Impala ABM / LZCNT support
......................................................................


Patch Set 3:

(2 comments)

This got stuck in my review backlog, sorry to take so long to look at it.  Based on the benchmarks,
seems like a win.

http://gerrit.cloudera.org:8080/#/c/5821/3/be/src/benchmarks/bit-intrinsics-benchmark.cc
File be/src/benchmarks/bit-intrinsics-benchmark.cc:

Line 26: //                RoundUpToPowerOfTwo           2.15e+03 2.17e+03  2.2e+03      1.75X
     1.74X      1.75X
It's interesting that it's faster even with the runtime CpuInfo check.


http://gerrit.cloudera.org:8080/#/c/5821/3/be/src/util/bit-util.h
File be/src/util/bit-util.h:

Line 64
This implementation had been bugging me for a while, since this function gets used all over
the place.


-- 
To view, visit http://gerrit.cloudera.org:8080/5821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message