impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client
Date Wed, 19 Apr 2017 00:21:16 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6627/5/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

Line 301:     if (!details.empty()) error_log_ss << "\n" << details;
Offline we discussed that we're going to try to remove the LogError() call from PlanFragmentExecutor::Exec()
since that's where the error message redundancy comes from. 

And we believe that LogError() (introduced at 89875939) is not necessary (after change 91db96d9
that added the code to get_log() to include query_status) to deal with the original problem
(of query status not showing up anywhere in beeswax, which doesn't have GetOperationStatus()).
Nor was it sufficient when the error occurs on the coordinator side, which is why reporting
query_status in get_log() is better.


-- 
To view, visit http://gerrit.cloudera.org:8080/6627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9d63610eb0d2acae3a9303ce46e1410727ce87
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message