impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5217: KuduTableSink checks null constraints incorrectly
Date Tue, 18 Apr 2017 20:34:22 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5217: KuduTableSink checks null constraints incorrectly
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

nice catch

http://gerrit.cloudera.org:8080/#/c/6670/1//COMMIT_MSG
Commit Message:

PS1, Line 8: 
           : KuduTableSink uses the referenced_columns map to translate between the index
into the
           : output exprs 'j' and the index into columns in the Kudu table 'col', but we incorrectly
           : use 'j' when calling into the Kudu table schema to check the nullability of columns.
nit: wrap msg please


-- 
To view, visit http://gerrit.cloudera.org:8080/6670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed458278f135288a821570939de8ee294183df2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message