impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3748: minimum buffer requirements in planner
Date Tue, 18 Apr 2017 16:10:37 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3748: minimum buffer requirements in planner
......................................................................


Patch Set 17: Code-Review+2

(3 comments)

Rebase

http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PipelinedPlanNodeSet.java
File fe/src/main/java/org/apache/impala/planner/PipelinedPlanNodeSet.java:

Line 126:       Preconditions.checkState(sinkProfile.getMemEstimateBytes() >= 0);
> this is already done in finalize()
Thanks for catching this, didn't finish moving it.

This actually masked a bug where we didn't compute resource profiles for build sinks when
generating the parallel plans.


http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PlanFragment.java
File fe/src/main/java/org/apache/impala/planner/PlanFragment.java:

Line 151:    * Finalize plan tree and create stream sink, if needed.
> update comment
Done


http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PlanNode.java
File fe/src/main/java/org/apache/impala/planner/PlanNode.java:

Line 621:    * Compute resources consumed when executing this PlanNode, initializing
> i'd simply mention the member var explicitly
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e358182bcf2bc5fe5c73883eb97878735b12d37
Gerrit-PatchSet: 17
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message