impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5145 : Do not constant fold null in CastExprs
Date Tue, 18 Apr 2017 04:41:03 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5145 : Do not constant fold  null in CastExprs
......................................................................


Patch Set 1:

(6 comments)

Minor comments, changes look good.

http://gerrit.cloudera.org:8080/#/c/6663/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5145 : Do not constant fold  null in CastExprs
extra space after IMPALA-5145, should be
IMPALA-5145: ...


Line 9: Constant folding  null values in CastExprs cuases CTAS statements
extra space after "folding"


Line 10: to fail. This regresses with the behavior observed before constant
This regresses the observed behavior before constant folding was introduced.


http://gerrit.cloudera.org:8080/#/c/6663/1/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
File fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java:

Line 52:     // Do not constant fold cast(null as dataType)
... because we cannot preserve the cast-to type and that can lead to query failures, e.g.,
in a CTAS.


Line 53:     if(expr instanceof CastExpr) {
space after if


http://gerrit.cloudera.org:8080/#/c/6663/1/testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
File testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test:

Line 187: # IMPALA-5145: Do not constant fold  null in CastExprs
extra space fold 'null'


-- 
To view, visit http://gerrit.cloudera.org:8080/6663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message