impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5188: Sort the slots in a tuple before serializing to Thrift
Date Tue, 18 Apr 2017 02:29:31 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to Thrift
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6610/1/be/src/runtime/descriptors.cc
File be/src/runtime/descriptors.cc:

Line 344:   // The vectors get copied because we intend to sort them and it is better to keep
this
> How about solving this in the FE?
It doesn't quite work. The corresponding expr trees need to be in the same order too.

Otherwise it hits a DCHECK: tuple.cc:379] Check failed: slot_desc->type().type == TYPE_NULL
|| slot_desc->type() == materialize_expr_ctxs[i]->root()->type()

Does it make sense to try to sort the exprs too?


-- 
To view, visit http://gerrit.cloudera.org:8080/6610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message