impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR
Date Mon, 17 Apr 2017 23:07:03 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5192: Don't bake MemPool* into IR
......................................................................


Patch Set 2:

(4 comments)

Thanks for the review.

http://gerrit.cloudera.org:8080/#/c/6657/2/be/src/codegen/codegen-anyval.h
File be/src/codegen/codegen-anyval.h:

Line 200:   /// If 'pool_val' is non-NULL, var-len data will be copied into 'pool_val'.
> We should explain that pool_val needs to be a MemPool*
Done


Line 208:   /// If 'pool_val' is non-NULL, var-len data will be copied into 'pool_val'.
> Same here
Done


Line 224:       llvm::Value* pool_val, llvm::BasicBlock* insert_before = nullptr);
> And here
Done


http://gerrit.cloudera.org:8080/#/c/6657/2/be/src/runtime/tuple.h
File be/src/runtime/tuple.h:

Line 165:   /// 'pool' may be NULL, in which case no pool-related code is generated. Otherwise
> Comment needs updating.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message