impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs
Date Mon, 17 Apr 2017 21:14:32 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
......................................................................


Patch Set 9:

(8 comments)

Unfortunate that we have to do this, but I can't think of a better way.

http://gerrit.cloudera.org:8080/#/c/5538/9/common/thrift/CMakeLists.txt
File common/thrift/CMakeLists.txt:

Line 189: # The thrift-generated java classes defined in TCLIService are also downloaded via
maven.
Can you expand the first sentence to explain in more detail why the download via Maven is
problematic?


http://gerrit.cloudera.org:8080/#/c/5538/9/fe/src/compat-hive-1/java/org/apache/impala/compat/MetaStoreShim.java
File fe/src/compat-hive-1/java/org/apache/impala/compat/MetaStoreShim.java:

Line 34: import org.apache.impala.authorization.User;
Why is there Impala stuff in here if this is a shim for the Hive Metastore? Seems cleaner
to keep them separate.


Line 44:  * A wrapper around some of Hive's metastore API's to abstract away differences
Metastore


Line 45:  * between major versions of hive. This implements the shimmed methods for Hive 2.
Hive


Line 47: public class MetaStoreShim {
Let's use "Metastore" and not "MetaStore". Impala uses the former consistently, I know Hive
is inconsistent there.


http://gerrit.cloudera.org:8080/#/c/5538/9/fe/src/compat-hive-2/java/org/apache/impala/compat/MetaStoreShim.java
File fe/src/compat-hive-2/java/org/apache/impala/compat/MetaStoreShim.java:

Line 44:  * A wrapper around some of Hive's metastore API's to abstract away differences
Metastore


Line 45:  * between major versions of hive. This implements the shimmed methods for Hive 2.
Hive


PS9, Line 100: p
This and the following functions look identical between the shim implementations, why keep
them in here?


-- 
To view, visit http://gerrit.cloudera.org:8080/5538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc265281c04fe3136bc3c920dbac966742ce09a
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message