impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681
Date Fri, 14 Apr 2017 19:16:11 GMT
Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681
......................................................................

IMPALA-5187: Bump breakpad version for Breakpad bug #681

Breakpad had an issue [1] with random GUID generation on Linux, that
lead to processes started within the same second to write minidumps to
the same filename. Only one would win and overwrite minidumps of the
other processes.

This change bumps the Breakpad version in the toolchain to include the
fix for the upstream bug. It will allow us to remove the workaround we
introduced to address IMPALA-3794. I tested this by reverting the
workaround, removing any startup delay from the cluster startup scripts,
and then verified that the test_breakpad.py passes.

This change also removes the patch to increase the maximum number of
threads for minidump_stackwalk, which has been merged upstream.

[1] https://bugs.chromium.org/p/google-breakpad/issues/detail?id=681

Change-Id: I52dba5035a425ab0b689437235ac82639fb99a27
---
M buildall.sh
A source/breakpad/breakpad-a9fca58305afcb16a7ae539d87d672c702aba3f1-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
2 files changed, 78 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/33/6633/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52dba5035a425ab0b689437235ac82639fb99a27
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message