impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive
Date Thu, 13 Apr 2017 23:19:14 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-2800: make memory maintenance less aggressive
......................................................................


Patch Set 3:

(2 comments)

how did you test this?

http://gerrit.cloudera.org:8080/#/c/6626/3//COMMIT_MSG
Commit Message:

PS3, Line 15: aggressive aggressive
maybe this is too aggressive


http://gerrit.cloudera.org:8080/#/c/6626/3/be/src/common/init.cc
File be/src/common/init.cc:

PS3, Line 97: ///
inconsistent use of // and ///


-- 
To view, visit http://gerrit.cloudera.org:8080/6626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message