impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5172: Buffer overrun for Snappy decompression
Date Thu, 13 Apr 2017 22:53:21 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5172: Buffer overrun for Snappy decompression
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6625/2/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

Line 146: 
it'd be good to add a short comment explaining what this test case does.


PS2, Line 147: LimitedBuffer
maybe TruncatedOutput would be clearer?


-- 
To view, visit http://gerrit.cloudera.org:8080/6625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45b75f61e8c0ae85f9add5b13ac2b161a803d2ba
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message