impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5172: Buffer overrun for Snappy decompression
Date Thu, 13 Apr 2017 22:50:40 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-5172: Buffer overrun for Snappy decompression
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6625/2/be/src/util/decompress.cc
File be/src/util/decompress.cc:

PS2, Line 467:           return Status(TErrorCode::SNAPPY_DECOMPRESS_DECOMPRESS_SIZE_INCORRECT);
> nit: Wondering if this is the right error message to return in SnappyBlockD
It would be good to clean up the error messages, but it is also not a new thing. We were already
returning SNAPPY_DECOMPRESS_SIZE_INCORRECT from this function.

It might make sense to have a new error that is specific to the output buffer being too small,
as that seems distinct from an actual decompression error.


-- 
To view, visit http://gerrit.cloudera.org:8080/6625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45b75f61e8c0ae85f9add5b13ac2b161a803d2ba
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message