impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive
Date Thu, 13 Apr 2017 22:32:43 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2800: make memory maintenance less aggressive
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6626/2/be/src/common/init.cc
File be/src/common/init.cc:

PS2, Line 147: but this is often not frequent enough
Should we consider increasing the default release rate from 1.0 to a larger value? Tcmalloc
allows setting it dynamically via SetMemoryReleaseRate()[1]. I'm not sure if that can have
any other side effects.

[1] https://github.com/gperftools/gperftools/blob/7822b5b0b9fa7e016e1f6b46ea86f26f4691a457/src/tcmalloc.cc#L785


-- 
To view, visit http://gerrit.cloudera.org:8080/6626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message