impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan.
Date Thu, 13 Apr 2017 01:53:04 GMT
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6618

to look at the new patch set (#2).

Change subject: IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan.
......................................................................

IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan.

The bug was that a failed CreateAndOpenScanner() could cause
a scanner to be closed twice leading to freed memory being
accessed. The fix is straightforward.

Testing:
- I cleaned up test_failpoints.py and added an MT_DOP test
  dimension to cover this bug.
- Core tests passed.

Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270
---
M be/src/exec/base-sequence-scanner.cc
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node-mt.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-scanner.h
M be/src/exec/hdfs-text-scanner.cc
M tests/failure/test_failpoints.py
9 files changed, 71 insertions(+), 67 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/6618/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message