impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan.
Date Thu, 13 Apr 2017 00:53:12 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan.
......................................................................


Patch Set 1:

Is HdfsScanner::Close() meant to be idempotent? If not, is it reasonable to add a DCHECK that
would detect this error more directly. 

It seems like this is a kind of bug should be easy to detect if we clean up after ourselves,
e.g. set invalid pointers to NULL or use smart pointers.

If this isn't easy to do this seems fine but it would be nice to prevent a reoccurrence of
a similar bug.

-- 
To view, visit http://gerrit.cloudera.org:8080/6618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message