impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5073: Part 1: add option to use mmap() for buffer pool
Date Wed, 12 Apr 2017 19:04:11 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5073: Part 1: add option to use mmap() for buffer pool
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6474/9/be/src/runtime/bufferpool/system-allocator.cc
File be/src/runtime/bufferpool/system-allocator.cc:

PS9, Line 27: Impala will 
> maybe delete that (to future proof in case this code is used in other appli
Done


Line 96: // code if we are compiling against an older kernel.
> nit: the indentation got weird here
Missed that. clang-format keeps wanting to do that.


http://gerrit.cloudera.org:8080/#/c/6474/9/be/src/util/memory-metrics.cc
File be/src/util/memory-metrics.cc:

Line 161:       value_ = pool.peak_committed;
> why format this one differently?
Done


PS9, Line 174: allocated
> system-allocated, or was there a reason you didn't rename here too?
Just an oversight.


-- 
To view, visit http://gerrit.cloudera.org:8080/6474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message