impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet
Date Wed, 12 Apr 2017 13:06:56 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

Patch Set 7:

File fe/src/main/java/org/apache/impala/analysis/

Line 113:           "Invalid time zone in the '%s' table property: %s",
> double 'the'
File fe/src/test/java/org/apache/impala/analysis/

Line 665: 
> Let's move all the CREATE/ALTER tests into a separate TestParquetMrInt96Wri

Line 1882:         "'  '", "URI path cannot be empty.");
> easier to read single quotes

Line 1904:           type == PrimitiveType.VARCHAR) {
> easier to read single quotes
File tests/custom_cluster/

Line 105:     parquet_path = get_fs_path(
> What does "fn" stand for? I'm thinking "file name", but this is not just a 
Renamed it to 'parquet_path'

Line 123:           ON = AND =  -- serves as a unique key
> easier to read with the alias 'i' next to the table

Line 125:           (h.timestamp_col IS NULL) != (i.timestamp_col IS NULL)
> simplify the first two conditions with:
Done. Had to put round brackets around col IS NULL expressions to avoid analysis errors.
File tests/query_test/

Line 78:   def test_invalid_parquet_mr_write_zone(self, vector, unique_database):
> test_invalid_parquet_mr_write_zone

Line 118:       # tz_name conversion on the timestamp values.
> extra space after "triggers"

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f24525ef45a2814f476bdee76655b30081079d6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Zoltan Ivanfi <>
Gerrit-HasComments: Yes

View raw message