impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5073: Use mmap() instead of malloc() for buffer pool
Date Wed, 12 Apr 2017 00:16:49 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5073: Use mmap() instead of malloc() for buffer pool
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6474/8/be/src/util/memory-metrics.h
File be/src/util/memory-metrics.h:

PS8, Line 161: TOTAL_ALLOCATED
how about SYSTEM_ALLOCATED?


PS8, Line 165: TOTAL_RESERVED
maybe just RESERVED, but I don't feel too strongly.


-- 
To view, visit http://gerrit.cloudera.org:8080/6474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message