impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.
Date Tue, 11 Apr 2017 17:58:29 GMT
John Russell has posted comments on this change.

Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea.
This is the last commit made by JRussell in the cleanup project.
......................................................................


Patch Set 1:

(2 comments)

I'll do some proofreading as a separate pass. Just wanted to get these comments in ASAP, about
.html files that can be removed.

http://gerrit.cloudera.org:8080/#/c/6604/1/docs/build/html/shared/ImpalaVariables.html
File docs/build/html/shared/ImpalaVariables.html:

PS1, Line 1: <!DOCTYPE html
           :   SYSTEM "about:legacy-compat">
           : <html lang="en"><head><meta http-equiv="Content-Type" content="text/html;
charset=UTF-8"><meta charset="UTF-8"><meta name="copyright" content="(C) Copyright
2017"><meta name="DC.rights.owner" content="(C) Copyright 2017"><meta name="DC.Type"
content="concept"><meta name="prodname" content="Impala"><meta name="version"
content="Impala 2.8.x"><meta name="DC.Format" content="XHTML"><meta name="DC.Identifier"
content="impala_vars"><link rel="stylesheet" type="text/css" href="../commonltr.css"><title>Impala
Variables</title></head><body id="impala_vars"><main role="main"><article
role="article" aria-labelledby="ariaid-title1">
           :   <h1 class="title topictitle1" id="ariaid-title1">Impala Variables</h1>
           :   
           :   <div class="body conbody">
           :     <div class="p">Substitution variables for denoting features available
in release X or higher.
           :        The upstream docs can refer to the Impala release number.
           :        The docs included with a distro can refer to the distro release number
by
           :        editing the values here.
           :        <ul class="ul">
           :         <li class="li"><span class="ph" id="impala_vars__impala28">Impala
2.8</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala27">Impala
2.7</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala26">Impala
2.6</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala25">Impala
2.5</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala24">Impala
2.4</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala23">Impala
2.3</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala22">Impala
2.2</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala21">Impala
2.1</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala20">Impala
2.0</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala14">Impala
1.4</span></li>
           :         <li class="li"><span class="ph" id="impala_vars__impala13">Impala
1.3</span></li>
           :       </ul>
           :     </div>
           :     <p class="p">Release Version Variable - <span class="ph" id="impala_vars__ReleaseVersion">Impala
2.8.x</span></p>
           :     <p class="p">Banner for examples showing shell version -<span class="ph"
id="impala_vars__ShellBanner">(Shell
           :       build version: Impala Shell v2.8.x (<var class="keyword varname">hash</var>)
built on
           :       <var class="keyword varname">date</var>)</span></p>
           :     <p class="p">Banner for examples showing impalad version -<span
class="ph" id="impala_vars__ImpaladBanner">Server version: impalad version 2.8.x (build
           :       x.y.z)</span></p>
           :     
           :   </div>
           : </article></main></body></html>
This whole file is not needed for the web site. Bits and pieces of text from this file are
reused in pages in the topics/ directory, but there are no links to this file itself:

$ grep 'ImpalaVariables.html' topics/*.html
$ grep 'impala_common.html' topics/*.html  
$

Much of the text on this page is actually for self-documentation and is only relevant to someone
who is editing the XML doc source.


http://gerrit.cloudera.org:8080/#/c/6604/1/docs/build/html/shared/impala_common.html
File docs/build/html/shared/impala_common.html:

PS1, Line 1: <!DOCTYPE html
           :   SYSTEM "about:legacy-compat">
           : <html lang="en"><head><meta http-equiv="Content-Type" content="text/html;
charset=UTF-8"><meta charset="UTF-8"><meta name="copyright" content="(C) Copyright
2017"><meta name="DC.rights.owner" content="(C) Copyright 2017"><meta name="DC.Type"
content="concept"><meta name="DC.Format" content="XHTML"><meta name="DC.Identifier"
content="common"><link rel="stylesheet" type="text/css" href="../commonltr.css"><title>Reusable
Text, Paragraphs, List Items, and Other Elements for Impala</title></head><body
id="common"><main role="main"><article role="article" aria-labelledby="ariaid-title1">
           : 
           :   <h1 class="title topictitle1" id="ariaid-title1">Reusable Text, Paragraphs,
List Items, and Other Elements for Impala</h1>
This whole file is not needed for the web site. Bits and pieces of text from this file are
reused in pages in the topics/ directory, but there are no links to this file itself:

$ grep 'ImpalaVariables.html' topics/*.html
$ grep 'impala_common.html' topics/*.html  
$

Much of the text on this page is actually for self-documentation and is only relevant to someone
who is editing the XML doc source.


-- 
To view, visit http://gerrit.cloudera.org:8080/6604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message