impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5073: Use mmap() instead of malloc() for buffer pool
Date Tue, 11 Apr 2017 17:35:01 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5073: Use mmap() instead of malloc() for buffer pool
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6474/7/be/src/runtime/bufferpool/system-allocator.cc
File be/src/runtime/bufferpool/system-allocator.cc:

Line 81:       munmap(mem, fixup);
> Yeah I couldn't find any way to mmap aligned memory (aside from actually sp
Regarding not calling from the system too often -- didn't you have to make adjustments to
the scavenging path for that?

If it turns out we do need to optimize this path, maybe easiest to amortize the cost by allocating
multiple buffers at a time when memory usage is ramping back up.


-- 
To view, visit http://gerrit.cloudera.org:8080/6474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message