impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5073: Use mmap() instead of malloc() for buffer pool
Date Tue, 11 Apr 2017 17:00:55 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5073: Use mmap() instead of malloc() for buffer pool
......................................................................


Patch Set 7:

I wonder if this is going to cause trouble with vm_overcommit set to 2, since tc_malloc doesn't
actually unmap its mappings (it just madvise(DONTNEED)).  So, it seems we can get into a situation
now where total virtual address space exceeds physical memory.  But I'm not sure how the kernel
accounts DONTNEED regions.

-- 
To view, visit http://gerrit.cloudera.org:8080/6474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message