impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3079: Fix sequence file writer
Date Mon, 10 Apr 2017 21:09:07 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3079: Fix sequence file writer
......................................................................


Patch Set 6:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/6107/6//COMMIT_MSG
Commit Message:

PS6, Line 11: Impala
wouldn't this bug mean that no one could read these files? i.e. they were completely invalid.


http://gerrit.cloudera.org:8080/#/c/6107/6/be/src/exec/read-write-util.h
File be/src/exec/read-write-util.h:

PS6, Line 223: i
what is 'i'? is this talking about 'val'?


PS6, Line 248: buff
buf


PS6, Line 259: buff
buf


PS6, Line 260: buff
buf


http://gerrit.cloudera.org:8080/#/c/6107/6/be/src/util/compress.cc
File be/src/util/compress.cc:

PS6, Line 209: its
what is this referring to? size of what?
and i think this comment would be clearer if reworded to explain the block encoding in order
(rather than "preceded with").


-- 
To view, visit http://gerrit.cloudera.org:8080/6107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message