impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs
Date Sun, 09 Apr 2017 10:44:19 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs
......................................................................


Patch Set 2:

(9 comments)

I marked more places that could be wrapped into a single line. I meant to say that there's
more of them than the one I highlighted in my last reply - apologies if that was not clear.
Now I should have caught all of them.

http://gerrit.cloudera.org:8080/#/c/6487/2/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

Line 38: # TODO: We need a better way of managing how these get set. See:
nit: single line?


Line 185:   # See IMPALA-4347
nit: single line?


Line 345:   # See IMPALA-4347
nit: single line?


Line 418:   # See IMPALA-4347
nit: single line?


http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

Line 837:       # IMPALA-2562.
nit: single line?


http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/discrepancy_searcher.py
File tests/comparison/discrepancy_searcher.py:

Line 193:               'IMPALA-865')
nit: single line?


Line 198:               'IMPALA-724')
nit: single line?


http://gerrit.cloudera.org:8080/#/c/6487/2/tests/custom_cluster/test_kudu_not_available.py
File tests/custom_cluster/test_kudu_not_available.py:

Line 47:       # IMPALA-3233
nit: single line?


http://gerrit.cloudera.org:8080/#/c/6487/2/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

Line 904:     # IMPALA-2234
nit: single line?


-- 
To view, visit http://gerrit.cloudera.org:8080/6487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28ea06e89341de234f9005fdc72a2e43f0ab8182
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message