impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm
Date Sat, 08 Apr 2017 19:37:58 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5189: Pin version of setuptools_scm
......................................................................


Patch Set 1:

(1 comment)

+1 to pinning the version, just need to remove the tarball

http://gerrit.cloudera.org:8080/#/c/6599/1/infra/python/deps/setuptools_scm-1.15.0.tar.gz
File infra/python/deps/setuptools_scm-1.15.0.tar.gz:

Please don't check in binary tarballs, I went to a lot of effort to strip this out from the
history.


-- 
To view, visit http://gerrit.cloudera.org:8080/6599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I398972d2cdf3acc9d5d8c598fc5b964b7241f1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message