impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm
Date Sat, 08 Apr 2017 17:35:50 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5189: Pin version of setuptools_scm
......................................................................


Patch Set 1:

> Thanks, Lars.
 > 
 > How did you test this?

I ran this command in a new virtualenv:

pip install --no-binary --no-index --no-cache-dir --find-links infra/python/deps/ -r infra/python/deps/requirements.txt

However, now that setuptools_scm 1.15.4 has been released, this command even works without
the fix. So unless we feel we should pin the package to 1.15.0 anyways, this fix seems not
needed anymore.

-- 
To view, visit http://gerrit.cloudera.org:8080/6599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I398972d2cdf3acc9d5d8c598fc5b964b7241f1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message