impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs
Date Sat, 08 Apr 2017 12:56:11 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6487/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

Line 230:     AnalysisUtils.throwIfNotNull(getCachingOp(),
> nit: This should fit on the previous line now.
Done


http://gerrit.cloudera.org:8080/#/c/6487/2/shell/shell_output.py
File shell/shell_output.py:

Line 40:       error_msg = ("Prettytable cannot resolve string columns values that have "
> nit: this should fit on the previous line now.
Done


http://gerrit.cloudera.org:8080/#/c/6487/2/testdata/bin/compute-table-stats.sh
File testdata/bin/compute-table-stats.sh:

Line 28: IMPALAD=${IMPALAD:-localhost:21000}
> nit: this could go on a single line now.
Done


http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/discrepancy_searcher.py
File tests/comparison/discrepancy_searcher.py:

PS2, Line 153: HIVE-14871")
> Remove for consistency
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28ea06e89341de234f9005fdc72a2e43f0ab8182
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message