impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed
Date Sat, 08 Apr 2017 12:16:39 GMT
Hello Lars Volker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6528

to look at the new patch set (#2).

Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed
......................................................................

IMPALA-5031: Remove undefined behavior: left shift of large signed

Shifting large positive signed values is undefined when the result is
not "representable in the corresponding unsigned type of the result
type". Left shift of unsigned values is always defined. See the C++14
standard, section 5.8 [expr.shift], paragraph 2.

Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d
---
M be/src/exprs/bit-byte-functions-ir.cc
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/6528/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message