impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs
Date Fri, 07 Apr 2017 22:14:55 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-5180: Don't balk at non-deterministic exprs
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6575/2/fe/src/main/java/org/apache/impala/analysis/Expr.java
File fe/src/main/java/org/apache/impala/analysis/Expr.java:

Line 1052:   public boolean isStrictlyBoundBySlotIds(List<SlotId> slotIds) {
> I'm not a fan of this new function. It feels like a quick hack to solve a v
I just fixed the original function.  It is only called in two places so the change is easy
to reason about.

The first requirement turned out to require too much code restructuring - it is simpler to
just return false if the list of slot IDs is empty.  Otherwise, we have to duplicate or otherwise
mangle the code in both HdfsPartitionPruner and PartitionFilter.

We do require it to be analyzed, as the slotRef must be analyzed to get its slotId.


-- 
To view, visit http://gerrit.cloudera.org:8080/6575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91054c6bf017401242259a1eff5e859085285546
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message