impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3794: Workaround for Breakpad ID conflicts
Date Fri, 07 Apr 2017 21:58:44 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3794: Workaround for Breakpad ID conflicts
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6588/3//COMMIT_MSG
Commit Message:

PS3, Line 11: If two impalads start up within the same second
> May be add this briefly to the commit message if you think that helps.
Done


http://gerrit.cloudera.org:8080/#/c/6588/3/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 84:                                  max_minidumps=self.MAX_MINIDUMPS)
> indentation?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ae589f6eb5cbbfb860943214edc0e6415eeb862
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message