impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4883: Union Codegen
Date Fri, 07 Apr 2017 18:09:31 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4883: Union Codegen
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node-ir.cc
File be/src/exec/union-node-ir.cc:

PS6, Line 29: dst_batch->tuple_data_pool()
is this where that mem-pool in the class is used when codegening?  Why not use that mem-pool
here to make that clear and keep the paths more consistent in their use of memory?


http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node.cc
File be/src/exec/union-node.cc:

PS6, Line 113: abort codegen entirely.
this doesn't seem to match the code. wouldn't we have already filled in codegend_union_materialize_batch_fns_
for earlier children?  do we have a test case for this path?


http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node.h
File be/src/exec/union-node.h:

PS6, Line 68: Temporarily stores references to materialized tuples by a codegened function
i'm not sure what this means. MemPools don't store references, they contain chunks of memory
that can be allocated.

Is this trying to say that this mem-pool is used by the codegen version of MaterializeExprs
to materialize var-len slots?  And if so, why is it specific to codegen?


PS6, Line 71: TODO: Remove this when no longer necessary in the future.
do we have a concrete jira for when this won't be necessary?


PS6, Line 96: Jitted
usually we say "codegen'ed"


-- 
To view, visit http://gerrit.cloudera.org:8080/6459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message