impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3794: Workaround for Breakpad ID conflicts
Date Fri, 07 Apr 2017 17:02:40 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3794: Workaround for Breakpad ID conflicts
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6588/3//COMMIT_MSG
Commit Message:

PS3, Line 11: If two impalads start up within the same second
Are you sure about this? The startup script has a sleep(1) between each each start command.


  # Start each impalad instance and optionally redirect the output to a log file.
  for i in range(cluster_size):
    if i == 0:
      # The first impalad always logs to impalad.INFO
      service_name = "impalad"
    else:
      service_name = "impalad_node%s" % i
      # Sleep between instance startup: simultaneous starts hurt the minikdc
      # Yes, this is a hack, but it's easier than modifying the minikdc...
      # TODO: is this really necessary?
      sleep(1)

    print "Starting Impala Daemon logging to %s/%s.INFO" % (options.log_dir,
        service_name)

I'm not aware of how breakpad determines the ID of the minidump but just want to be sure that
we are fixing the right thing. Otherwise the patch lgtm.


-- 
To view, visit http://gerrit.cloudera.org:8080/6588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ae589f6eb5cbbfb860943214edc0e6415eeb862
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message