impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5182: Explicitly close connection to impalad on error from shell
Date Fri, 07 Apr 2017 05:46:10 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5182: Explicitly close connection to impalad on error from shell
......................................................................


Patch Set 1:

(1 comment)

Were you able to repro the issue? Do you think it's easy/feasible to add a test?

http://gerrit.cloudera.org:8080/#/c/6587/1/shell/impala_shell.py
File shell/impala_shell.py:

Line 708:       # Secure connections may still be open. So we explicitly close it.
connection (singular)


-- 
To view, visit http://gerrit.cloudera.org:8080/6587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I814df93bbcd457ad3f96b4c1ef5d8b0ddd6d141f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message